Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make relative cursor based pagination work across page loads #625

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Make relative cursor based pagination work across page loads #625

merged 1 commit into from
Oct 22, 2019

Conversation

dnswus
Copy link
Contributor

@dnswus dnswus commented Oct 1, 2019

Extract page_info from next_url and previous_url to make cross relative cursor based pagination work across page loads.

Solving issue #624

@dnswus dnswus requested a review from a team as a code owner October 1, 2019 05:23
@ghost ghost added the cla-needed label Oct 1, 2019
@catsky
Copy link

catsky commented Oct 22, 2019

👍

@catsky
Copy link

catsky commented Oct 22, 2019

strongly suggest to merge this pull request, as this is very important function for pagination across multiple page loads.

@tanema
Copy link
Contributor

tanema commented Oct 22, 2019

We cannot merge this until the CLA is signed

@dnswus
Copy link
Contributor Author

dnswus commented Oct 22, 2019

I have signed after created this PR, but it's not updated here. Should I create a new one?

@ghost ghost removed the cla-needed label Oct 22, 2019
@katiedavis katiedavis merged commit 24d2640 into Shopify:master Oct 22, 2019
@tanema
Copy link
Contributor

tanema commented Oct 22, 2019

Thanks @dnswus apparently the check needed to be re-run but @katiedavis got it for us 💯

@ignacio-chiazzo ignacio-chiazzo temporarily deployed to rubygems December 23, 2019 18:09 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiedavis katiedavis katiedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dnswus @catsky @tanema @katiedavis @ignacio-chiazzo